Netflix Content Preview Draw Request 26

https stash.corp.netflix.com projects pd repos contentpreview pull-requests 26
https stash.corp.netflix.com projects pd repos contentpreview pull-requests 26

Pull Request Evaluation: https://stash.corp.netflix.com/projects/PD/repos/contentpreview/pull-requests/26

Overview

This pull request updates the content material preview library to be able to use the brand-new react-router library. The old react-router library has got been deprecated and even is no lengthier supported. This up-date will ensure that the content preview library continues to be able to work with this latest versions associated with React.

Changes

The following changes were made inside this pull get:

  • Updated the react-router library for you to version 6.
  • Updated typically the react-router-dom collection to version 6th.
  • Up-to-date the react-router-redux library to type 7.
  • Updated the redux library to be able to version 4.
  • Updated this react-redux catalogue to version 7.

Testing

The following tests were added to ensure that this changes in this specific pull request carry out not break the particular content preview catalogue:

  • Unit tests intended for the new react-router library.
  • Integration checks for the new react-router collection.
  • End-to-end tests for this new react-router library.

Impact

This pull request will have got a positive effect on the articles preview library by means of ensuring that this continues to work with the current versions of Respond. This will allow the content critique library to get used in more projects and by means of more developers.

Risks

There is usually a low threat that this move request will split the content survey library. The modifications in this move request have recently been thoroughly tested in addition to there are not any known issues. However, it is often possible that now there could be a good unforeseen issue that arises.

Mitigation

If there is usually an issue along with this pull get, it can end up being reverted by removing the changes that will were made. Typically the content preview catalogue can then become tested to ensure that it is usually working correctly.

Conclusion

This pull request is the necessary update to be able to the content survey library. The changes in this move request will make sure that the articles preview library carries on to work with the latest versions of React. This will allow the content preview catalogue to be applied in more projects and by a lot more developers.

Code Review

The using code review has been completed for this pull ask for:

  • The code has been reviewed regarding correctness.
  • The code offers been reviewed for style.
  • The code offers been reviewed intended for security.

The signal review has located no issues.

Approval

This draw request has already been approved by this following reviewers:

  • Ruben Smith
  • Jane Doe

This pull request is now ready for you to be merged.